Private AI code review

Never let another company into your codebase while outperforming SOTA code review tools.

Back to home

velnora-lab/invoice-service

HIGHConfidence: HIGHsrc/services/read-invoice.ts:44–45

Reviewed code6d91c8a4f0

  id: string) {  const hit = cache.get(id);  if (hit) return hit;  const row = await load(id);  requireAccount(actor, row);

Cached invoices bypass the account check. Ran npm test -- invoice-access.test.ts with separate accounts sharing a cache. Loaded an invoice as its owner, then requested the same id from the other account. The request returned the cached invoice without calling requireAccount. The test expected access to be denied and failed.

  • Several AI agents review each pull request

    They check correctness and effects on other repositories from different angles. They also check the project’s specifications when Cowboy has configured them.

  • A separate agent checks a suspected problem

    It must show the input that triggers the problem and cite the file and line before the problem becomes a finding. It can run targeted tests or builds.

  • Unproved concerns stay apart from findings

    High-severity concerns Marshal cannot confirm appear under Needs verification in the review comment.

How a review works

  1. A push starts the review

    Opening a pull request or pushing a new commit starts a review. Marshal’s check shows it running.

  2. Marshal posts its review on the pull request

    The comment gives the review result and explains the findings.

  3. Reply to mark a finding fixed or ignored

    Mention @cowboy-marshal in a reply with FIXED or IGNORE followed by the finding id. Marshal replies with the outcome. Marking a finding fixed does not verify the fix.

tavi-velnora added 1 commit 12 minutes ago

Add shared cache for invoice reads6d91c8a

  • marshal / deep reviewDetails
cowboy-marshalbotcommented9 minutes ago

Marshal deep review: needs_human

Reviewed the shared invoice cache, which returns cached invoices before the account check.

Specifications: velnora-lab/service-contracts@5db7ca4 (main at review start)

Findings (1)

HIGH · Confidence: HIGH · src/services/read-invoice.ts:44-45

Cached invoices bypass the account check.

Ran npm test -- invoice-access.test.ts with separate accounts sharing a cache. Loaded an invoice as its owner, then requested the same id from the other account. The request returned the cached invoice without calling requireAccount. The test expected access to be denied and failed.

src/services/read-invoice.ts:44–45 · lines 40 to 49 · > marks reported lines

  40 | async function readInvoice(  41 |   actor: Actor,  42 |   id: string  43 | ) {> 44 |   const hit = cache.get(id);> 45 |   if (hit) return hit;  46 |   const row = await load(id);  47 |   requireAccount(actor, row);  48 |   cache.set(id, row);  49 |   return row;

Finding id: e7b4c9a2

To accept a finding, reply with @cowboy-marshal IGNORE <id>. To mark it fixed, use @cowboy-marshal FIXED <id>. The mention may also follow the command. Put each command on its own line; all commands in your reply are processed.

tavi-velnoracommentednowMemberAuthor

@cowboy-marshal FIXED e7b4c9a2

cowboy-marshalbotcommentednow

Finding updates requested by @tavi-velnora:

  • e7b4c9a2: marked fixed.

What guides a review

  1. Configured specifications guide the review

    When Cowboy configures specifications for a repository, Marshal checks the change against the referenced text. The comment names the specifications repository and prepared revision.

  2. How Marshal uses CLAUDE.md

    Marshal is given the repository’s CLAUDE.md files as notes on the project’s conventions.

  3. Who can answer a finding

    Only repository owners, members and collaborators can answer. Marshal ignores bot and outside comments, quoted text and code examples.

Make serious findings block the merge

When your repository requires Marshal’s check, a high-severity finding stops the pull request from merging.

Merge held

  • marshal / deep review — Marshal deep review: needs_humanDetails
  • delivery/review — delivery/review: BLOCKEDDetails
  • delivery/ci — delivery/ci: NOT_REQUESTEDDetails
  • Gatekeeper review — ApproveDetails

Checks passed

  • marshal / deep review — Marshal deep review: passDetails
  • delivery/review — delivery/review: PASSDetails
  • delivery/ci — delivery/ci: PASSDetails
  • Gatekeeper review — ApproveDetails
  • The finding fails the check

    The merge stays blocked while Marshal’s check is failing.

  • Clearing the hold takes a recheck

    Only Marshal’s review of the new code can clear it.

  • Earlier findings stay in review

    Every new commit gets checked against earlier findings, even those marked fixed or ignored.

Marshal reviews General Store actors

Cowboy is the App Store for AI. Find agents, skills, compute, feeds and models in the General Store.

Actors are Cowboy’s agents. Each passes Marshal’s review before General Store approval. The actor you hire runs exactly the code Marshal reviewed.

  • The actor runs as your own instance

    It stores its secrets there and uses your own keys.

  • The manifest limits connections

    An actor can reach only the hosts listed in its manifest.

  • How files and secrets are stored

    Private files have their own encryption key. Secrets are held in a threshold secret store.

Request access to Marshal